-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mask-origin and mask-clip use removed property margin-box #678
Comments
It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
I've commented on the existing issue above and created a linked pull request to change from to . If it gets approved then it makes this issue much easier to solve as we just make the change here as well |
Since the issue and related pull request above have been closed, these pages now use |
As per mdn/content#28157,
margin-box
is no longer a possible value formask-origin
andmask-clip
, but the formal syntax sections here and here still contain them.The syntax for them can be found here and here, in both cases all they do is set
<geometry-box>
which contains<shape-box>
and thereforemargin-box
as a property. Confusingly the W3 spec says they are still use<geometry-box>
(here and here), which does still containmargin-box
, yet also saysmargin-box
is no longer a possible value formask-origin
andmask-clip
(here), so I'm not sure what the best way to go about removingmargin-box
as a property would be.<geometry-box>
is defined here and<shape-box>
here. I don't thinkmargin-box
can be removed as a property of<shape-box>
as it's still a valid property for that, and other syntaxes that are supposed to supportmargin-box
do use<shape-box>
. One option might be to create another<geometry-box>
and<shape-box>
specifically for mask-origin and mask-clip, which don't contain<margin-box>
. Another might be to manually list all of the possible values ofmask-origin
andmask-clip
instead of using<geometry-box>
to do this, but that wouldn't then match the W3 syntax which does use<geometry-box>
.Is there any way of removing/altering the properties created by using an object in syntaxes.json, ie removing margin-box while still using the existing
<geometry-box>
and<shape-box>
objects? If so that seems like it'd be the best way of approaching this, but I don't know if that'd be possible or how it'd be done.The text was updated successfully, but these errors were encountered: