Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localized strings for background-position-x percentages are wrong #627

Closed
wbamberg opened this issue Nov 30, 2022 · 0 comments · Fixed by #629
Closed

Localized strings for background-position-x percentages are wrong #627

wbamberg opened this issue Nov 30, 2022 · 0 comments · Fixed by #629

Comments

@wbamberg
Copy link
Contributor

#625 fixed an issue where the "percentages" bit for background-position-x incorrectly used height instead of width. But it only addressed en-US, and AFAICT the translated versions are still incorrect.

cc @mdn/localization-team-leads - if you file PRs to address this please tag me for a review :)
@wbamberg wbamberg changed the title Localized strings for background-position-x percentages is wrong Localized strings for background-position-x percentages are wrong Nov 30, 2022
@SphinxKnight SphinxKnight mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Follow-up of #625 for fr SphinxKnight/data
1 participant
@wbamberg