Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on at-rule syntax description #222

Open
lahmatiy opened this issue May 6, 2018 · 0 comments
Open

Improvements on at-rule syntax description #222

lahmatiy opened this issue May 6, 2018 · 0 comments
Labels
idle Issues and pull requests with no activity for three months.

Comments

@lahmatiy
Copy link
Contributor

lahmatiy commented May 6, 2018

There are some syntax description issues in css/at-rule.json:

  • @charset \"<charset>\"; is quite incorrect, should be @charset <string> ;
  • @counter-style has a description of block, but declaration refers to wrong types (i.e. system: <counter-system>; but system key in descriptors)
  • @font-face had a problem with wrong reference like in @counter-style syntax, but I fixed it in Fix a syntax errors for @font-face #221
  • <group-rule-body> is wrong for the block of @viewport (should be a list of descriptors)

I think we need to change the description of @counter-style, @font-face and @viewport, since those at-rules have a limited list of descriptors and block syntax can be generated from a descriptors section. The rest at-rule descriptions should be revisited too.
I can bring a PR later if there is no blockers for changes (like MDN pages).

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

No branches or pull requests

1 participant