Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css/properties.json is incomplete #149

Closed
Kapeli opened this issue Nov 11, 2017 · 9 comments
Closed

css/properties.json is incomplete #149

Kapeli opened this issue Nov 11, 2017 · 9 comments

Comments

@Kapeli
Copy link

Kapeli commented Nov 11, 2017

Some properties that are missing from css/properties.json:

  • justify-items
  • justify-self
@teoli2003
Copy link
Member

Hi! thanks for finding this!

Do you think you could submit a PR for these?

@Kapeli
Copy link
Author

Kapeli commented Nov 13, 2017

I tried, but I have no idea what to fill in for the syntax and other fields. Also, the file should be checked for other missing properties as well? Not sure how to do that either.

@meyer
Copy link

meyer commented Dec 4, 2017

@teoli2003 What’s the best source of truth for what should be in this repository?

https://www.w3.org/TR/css-2017/ ??
https://github.com/w3c/csswg-drafts ??
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference ??

I’d love to contribute. Just not sure where to start.

@teoli2003
Copy link
Member

Hi!
Things are a little bit more complex, unfortunately. There is no ultimate source of truth existing on the Web.

Properties that are listed here are the ones that has been/are implemented by one browser that shipped. [We can make some exceptions, but that it the idea]

Then for the values of each entry, that is syntax and so, we prime the implementations. If they diverge, we usually follow the spec if it tries to solve the divergence.

CSS 2017 is usually a good start, though I'm not sure about the implementation status (in browsers) of things like CSS Speech, but we will definitively incoroporate additional drafts. The MDN link you gave should use this data/properties.json as a source of truth.

Hope it helps.

@Kapeli
Copy link
Author

Kapeli commented Apr 4, 2018

Thank you @pkuczynski! 🙏

@wbamberg
Copy link
Contributor

wbamberg commented Apr 5, 2018

#184 is still open.

@wbamberg wbamberg reopened this Apr 5, 2018
@pkuczynski
Copy link
Contributor

#184 and #185 are closed, so this issue can be closed too @wbamberg and @lahmatiy

@pkuczynski
Copy link
Contributor

You welcome @Kapeli

@pkuczynski
Copy link
Contributor

@wbamberg shall we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants