Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mdn/data
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.1
Choose a base ref
...
head repository: mdn/data
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.2
Choose a head ref
  • 3 commits
  • 7 files changed
  • 3 contributors

Commits on Dec 28, 2023

  1. fix: descriptions of discrete animation behavior between visible and … 

    …hidden (#690)

<!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

### Description

In #688, part of the work was to add
descriptions of the new specific animation behavior of certain
"discrete" animated properties — `display`, `content-visibility`, and
`overlay` — when animating from a hidden state or a visible state.
However, on talking to some Chrome engineering folks about this, I
realized that some of my descriptions were not quite right.

This PR aims to fix those descriptions.

The description I was sent by the Chrome engineering folk is as follows:

"The idea behind "p = 1" is that during transitions between certain
values for certain properties which we consider invisible to visible or
vice versa, the browser will automatically choose the "visible" option
for the duration of the animation it creates.
For example, if you transition from "display:none" to "display:block",
the element will be "display:block" for the entire animation created by
the transition.
And likewise if you transition from "display:block" to "display:none",
the element will be "display:block" for the entire animation created by
the transition.
However, if you transition from "display:flex" to "display:block", the
element's display value will switch halfway through the animation.
This behavior is applied to content-visibility:hidden, display:none,
visibility:hidden, and overlay:none."

<!-- ✍️ Summarize your changes in one or two sentences -->

### Motivation

<!-- ❓ Why are you making these changes and how do they help? -->

### Additional details

<!-- 🔗 Link to documentation, bug trackers, source control, or other
places providing more context -->

### Related issues and pull requests

<!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" -->
<!-- 👉 Highlight related pull requests using "Relates to #123" -->
<!-- ❗ If another pull request should be merged first, use "**Depends
on:** #123" -->
    @chrisdavidmills
    chrisdavidmills authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    eb3bd6b View commit details
    Browse the repository at this point in the history

  2. Remove CSS at-rule @Viewport (#677) 

    <!-- 🙌 Thanks for contributing! Adding details below will help us to
merge your PR faster. -->

### Description

Remove CSS at-rule @Viewport

### Motivation

This at-rule has been removed from spec CSS Viewport Module Level 1

### Additional details

w3c/csswg-drafts#7670

### Related issues and pull requests

N/A
    @mems
    mems authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    4bfc96b View commit details
    Browse the repository at this point in the history

  3. chore(main): release 2.3.2 (#699) 

    🤖 I have created a release *beep* *boop*
---


## [2.3.2](v2.3.1...v2.3.2)
(2023-12-28)


### Bug Fixes

* descriptions of discrete animation behavior between visible and hidden
([#690](#690))
([eb3bd6b](eb3bd6b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282 github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    03779ab View commit details
    Browse the repository at this point in the history
Loading