Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert callout noteblocks to GFM syntax #35066

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Convert callout noteblocks to GFM syntax #35066

merged 1 commit into from
Jul 25, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR converts all of the callout noteblocks to GFM syntax, using https://github.com/queengooborg/mdn-toolkit/blob/main/upgrade-noteblock.js.

@queengooborg queengooborg requested review from a team as code owners July 25, 2024 16:28
@queengooborg queengooborg requested review from Elchi3, chrisdavidmills and scottaohara and removed request for a team July 25, 2024 16:28
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:Learn Learning area docs Content:Learn:JavaScript Learning area JavaScript docs Content:Learn:CSS Learning area CSS docs Content:Learn:HTML Learning area HTML docs Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:Forms Learning area Forms docs Content:Learn:Cross-Browser-Testing Learning area Cross-Browser-Testing docs size/m [PR only] 51-500 LoC changed labels Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (56 pages)
Flaws (1)

Note! 55 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/Reference
Title: CSS reference
Flaw count: 1

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Web/CSS/::cue-region

Josh-Cena
Josh-Cena approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convenient :)

@Josh-Cena Josh-Cena merged commit 70f49e7 into main Jul 25, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the callout branch July 25, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-html

@scottaohara scottaohara Awaiting requested review from scottaohara scottaohara is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Learn:Accessibility Accessibility documentation in the Learn Area Content:Learn:Cross-Browser-Testing Learning area Cross-Browser-Testing docs Content:Learn:CSS Learning area CSS docs Content:Learn:Forms Learning area Forms docs Content:Learn:HTML Learning area HTML docs Content:Learn:JavaScript Learning area JavaScript docs Content:Learn Learning area docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Josh-Cena