Remove api.PageRevealEvent.PageRevealEvent from BCD #23707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the `PageRevealEvent` member of the `PageRevealEvent` API from BCD. Per the [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#removal-of-irrelevant-features), this feature can be considered irrelevant and may be removed from BCD accordingly. Even if the current data suggests that the feature is supported, lack of support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.11.0). Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent/PageRevealEvent
queengooborg
added
the
data:api 🐇
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
queengooborg
added
the
needs content update 📝
github-actions
bot
removed
the
merge conflicts 🚧
queengooborg
removed
the
needs content update 📝
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
Elchi3
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
I don't see the constructor in https://source.chromium.org/chromium/chromium/src/ /main:third_party/blink/renderer/core/view_transition/page_reveal_event.idl so this seems to be correct.
|
This is a supporting feature for authors to work with cross-document view transitions. It is expected that, today, usage is low. I'm currently OOO but maybe @noamr can chime in to why the constructor doesn't show up in the IDL? |
It's an oversight, filed https://issues.chromium.org/issues/354588516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
PageRevealEventmember of thePageRevealEventAPI from BCD. Per the data guidelines, this feature can be considered irrelevant and may be removed from BCD accordingly. Even if the current data suggests that the feature is supported, lack of support has been confirmed by the mdn-bcd-collector project (v10.11.0).Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent/PageRevealEvent