-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature-order lint doesn't check global_attributes #23549
Comments
It appears that this is caused by the check to see if an object has a Ultimately, I think that this is a fatal flaw in the way that the ordering script is programmed. Since we're using the replacer parameter of To solve this, I believe that a rewrite of the ordering script(s) would be needed. The ordering script would need to be written in a way where we can track the current path and depth, track what kind of object (relative to the schema) we're modifying, and ultimately, ensure we're sorting everything we can. This would also be a good opportunity to merge the ordering scripts into one script. |
What type of issue is this?
Linter issue
What is the issue?
The features in https://github.com/mdn/browser-compat-data/blob/main/svg/global_attributes.json are not sorted alphabetically.
What behavior were you expecting?
https://github.com/mdn/browser-compat-data/blob/main/svg/global_attributes.json to be sorted alphabetically (or the linter complaining about it.)
What version(s) of BCD is the issue present in?
main
branchDo you have anything more you want to share?
Same problem in https://github.com/mdn/browser-compat-data/blob/main/html/global_attributes.json too
The text was updated successfully, but these errors were encountered: