Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Upgrade' version of k8s.io/client-go to proper format #1083

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

nickmisasi
Copy link
Contributor

Summary

In #1017 the version of this package was changed from v0.27.2 to v1.5.2 while on the surface this appears to be an upgrade, it was actually a downgrade. The package itself seems to have changed up it's versioning scheme with the introduction of Go modules in go1.16 - see the README here. This PR returns the package version to the proper way, and upgrades it to the latest minor version. This enables other projects to use go get against the Provisioner.

Ticket Link

N/a

Release Note

None

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 16, 2024
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@nickmisasi nickmisasi merged commit 6989af0 into master Oct 17, 2024
5 checks passed
@nickmisasi nickmisasi deleted the client-go-upgrade branch October 17, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants