Strengthen coverage for CustomFilter model
#32479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yup! |
mjankowski
force-pushed
the
spec-model-validation-custom-filter
branch
2 times, most recently
from
265a935 to
9615fff
Compare
mjankowski
force-pushed
the
spec-model-validation-custom-filter
branch
from
9615fff to
cafa771
Compare
mjankowski
force-pushed
the
spec-model-validation-custom-filter
branch
2 times, most recently
from
479575c to
5e9c7e0
Compare
|
Would this be easier reviewed with the added |
mjankowski
force-pushed
the
spec-model-validation-custom-filter
branch
from
5e9c7e0 to
d825177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #31775
Improve validation specs, add
expires_incoverage.Future thing - this model includes the expireable module and also has its own
expires_in(which takes precedence). This is fine, and I think desired, may want to double-check/rename and/or see if the logic here would be relevant/desirable to other spots which include the module.