Fix empty authors preview card serialization (#33151)

mastodon · Dec 4, 2024 · e5bea68 · e5bea68
1 parent 6fddf16
commit e5bea68
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 1 deletion.
diff --git a/app/models/preview_card.rb b/app/models/preview_card.rb
@@ -134,7  134,7 @@ def history
   end
 
   def authors
-    @authors ||= [PreviewCard::Author.new(self)]
     @authors ||= Array(serialized_authors)
   end
 
   class Author < ActiveModelSerializers::Model
@@ -169,6  169,13 @@ def image_styles(file)
 
   private
 
   def serialized_authors
     if author_name? || author_url?
       PreviewCard::Author
         .new(self)
     end
   end
 
   def extract_dimensions
     file = image.queued_for_write[:original]
 

diff --git a/spec/serializers/rest/preview_card_serializer_spec.rb b/spec/serializers/rest/preview_card_serializer_spec.rb
@@ -0,0  1,41 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
 
 RSpec.describe REST::PreviewCardSerializer do
   subject do
     serialized_record_json(
       preview_card,
       described_class
     )
   end
 
   context 'when preview card does not have author data' do
     let(:preview_card) { Fabricate.build :preview_card }
 
     it 'includes empty authors array' do
       expect(subject.deep_symbolize_keys)
         .to include(
           authors: be_an(Array).and(be_empty)
         )
     end
   end
 
   context 'when preview card has author data' do
     let(:preview_card) { Fabricate.build :preview_card, author_name: 'Name', author_url: 'https://host.example/123' }
 
     it 'includes populated authors array' do
       expect(subject.deep_symbolize_keys)
         .to include(
           authors: be_an(Array).and(
             contain_exactly(
               include(
                 name: 'Name',
                 url: 'https://host.example/123'
               )
             )
           )
         )
     end
   end
 end