Make stable compliant #4314
Merged
Make stable compliant #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove bound_map feature * restore rust-toolchain
* remove variant_count feature * fix VariantCount for ComponentState
|
Behavior that change : In storage we don"t remove the non-existing refs of the other storage in an |
modship
reviewed
Aug 23, 2023
|
Need #4364 to pass in review. |
damip
reviewed
Aug 24, 2023
|
@AurelienFT how about we move to https://github.com/rust-lang/rust/releases/tag/1.72.0 and stay there ? |
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
damip
reviewed
Aug 30, 2023
Leo-Besancon
approved these changes
Aug 30, 2023
| }; | ||
| if next_refresh <= Instant::now() { | ||
| let now = Instant::now(); | ||
| let duration = (start_time + tick).saturating_duration_since(Instant::now()); |
There was a problem hiding this comment.
why not use now directly here?
There was a problem hiding this comment.
because i"m dumb :) Fixed. ty
massa-pool-worker/src/worker.rs
Outdated
| let now = Instant::now(); | ||
| let duration = (start_time + tick).saturating_duration_since(Instant::now()); | ||
| if !duration.is_zero() { | ||
| let duration = start_time + tick - now; |
There was a problem hiding this comment.
Why do you recompute duration here? Can"t you just use its value?
There was a problem hiding this comment.
because i"m dumb :). Fixed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.