Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mem leak in versioning stats + only update states if not final #4169

Merged
merged 7 commits into from
Jul 3, 2023
Merged

Fix mem leak in versioning stats + only update states if not final #4169

merged 7 commits into from
Jul 3, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jun 28, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds mentioned this pull request Jun 28, 2023
Closed
4 tasks
@sydhds sydhds force-pushed the feature/versioning_mem_leak_stats_1 branch from 7a66fbf to 2e9d486 Compare June 29, 2023 09:46
@sydhds sydhds marked this pull request as ready for review June 29, 2023 10:12
@sydhds sydhds requested review from damip and Leo-Besancon June 29, 2023 10:12
Leo-Besancon
Leo-Besancon reviewed Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review

massa-execution-exports/src/types.rs Outdated Show resolved Hide resolved
massa-final-state/src/final_state.rs Show resolved Hide resolved
massa-versioning/src/versioning.rs Outdated Show resolved Hide resolved
sydhds
sydhds commented Jun 29, 2023
View reviewed changes
massa-versioning/src/versioning.rs Show resolved Hide resolved
massa-execution-exports/src/types.rs Outdated Show resolved Hide resolved
massa-versioning/src/versioning.rs Outdated Show resolved Hide resolved
@sydhds sydhds requested review from damip and Leo-Besancon June 29, 2023 16:31
@sydhds sydhds mentioned this pull request Jun 30, 2023
Closed
@sydhds sydhds force-pushed the feature/versioning_mem_leak_stats_1 branch from c0d97e2 to 1bbd3dd Compare July 3, 2023 07:42
damip
damip reviewed Jul 3, 2023
View reviewed changes
massa-versioning/src/versioning.rs Outdated
@@ -672,26 +679,29 @@ impl<const N: usize> TryFrom<([(MipInfo, MipState); N], MipStatsConfig)> for Mip
#[derive(Debug, Clone, PartialEq)]
pub struct MipStatsConfig {
pub block_count_considered: usize,
pub counters_max: usize,
// pub counters_max: usize,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

damip
damip approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@sydhds sydhds merged commit b5ad893 into testnet_24 Jul 3, 2023
@sydhds sydhds deleted the feature/versioning_mem_leak_stats_1 branch July 3, 2023 08:45
@sydhds sydhds mentioned this pull request Jul 4, 2023
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydhds @damip @Leo-Besancon