o Fix missing header (unistd.h needed for close()) #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o Fix verbose and slow way to append to a std::string by using the method that is meant for that. Looks like someone in the past was confused with c strings that can hold binary data vs. c strings that are NUL terminated and did some laborious workaround. o Remove leftover debugging code of the c /c confusion. o While at it: fix a couple of trailing spaces. o Makefile fixes.
|
(ping) |
seblemaguer
added a commit
that referenced
this pull request
Dec 9, 2015
o Fix missing header (unistd.h needed for close())
|
Hello, thanks a lot, I didn't had time to review it before but now it's done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o Fix verbose and slow way to append to a std::string by using the
method that is meant for that. Looks like someone in the past
was confused with c strings that can hold binary data vs.
c strings that are NUL terminated and did some laborious
workaround.
o Remove leftover debugging code of the c /c confusion.
o While at it: fix a couple of trailing spaces.
o Makefile fixes.