Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared-lib-calls-exit #41

Open
awissu opened this issue Oct 14, 2014 · 1 comment
Open

shared-lib-calls-exit #41

awissu opened this issue Oct 14, 2014 · 1 comment
Labels

Comments

@awissu
Copy link

awissu commented Oct 14, 2014

Hello!
I to build package (marsyas-0.4.8) and in OBS RPMlint the following warning:

libmarsyas0.i586: W: shared-lib-calls-exit /usr/lib/libmarsyas.so.0.4.8 exit@GLIBC_2.0
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

Thank you for the attention, hope this report helps development.

@jleben
Copy link
Contributor

jleben commented Oct 14, 2014

Thank you for reminding us of this problem. Indeed, Marsyas lacks proper error handling, and in most cases (e.g. if it can not open an audio device or sound file) will just abort the entire executing process!

@jleben jleben added the bug label Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants