Stop the selling & buying list having the same Good #1214
Conversation
Deals have the same Goods in the to sell and to Buy list which make no sense. This change prevents, for each Settlement, a Good in the buying list will not be added to the selling list. THe buying list takes priority. Changes: - GoodManager adds the Good in the buying list to the excluded Goods when creating the selling list. - Clean code smells in Good class Part of #1178
|
Can we merge these changes onto 3.7.x as well since it's considered a bug fix ? It's not like it's adding any new features. |
|
Well I don't think the impact of the problem justifies the bugfix. Its bit that easy because it may pick up a lot of other changes. You round have to cherry pick the commit |
I don't understand that.
have to cherry pick the commit ? what does it mean ? You only changed 2 files right ? I'll simply copy and paste the new contents to the 3.7.x branch. |
|
The issue was marked for 3.8.0 so that's is where it is fixed. |
1.9.2024 - Deals have the same Goods in the to sell and to Buy list which make no sense. - This change prevents, for each Settlement, a Good in the buying list will not be added to the selling list. The buying list takes priority. Changes: - GoodManager adds the Good in the buying list to the excluded Goods when creating the selling list. - Clean code smells in Good class Note: manually merge changes from Master branch Relates to #1178 and #1214
Deals have the same Goods in the to sell and to Buy list which make no sense. This change prevents, for each Settlement, a Good in the buying list will not be added to the selling list. The buying list takes priority.
Changes:
Close #1178