Fix paths containing unencoded ` followed by punctuation #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timjamello
force-pushed
the
support-unencoded-apostrophes
branch
from
7a39752
to
54247ad
Compare
timjamello
force-pushed
the
support-unencoded-apostrophes
branch
from
54247ad
to
a0b1cc5
Compare
timjamello
changed the title
|
@rlidwka do you think you could take a look at this? I noticed there is another PR in this repo that has gone stale, and I just want to make sure this one gets looked at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkify-it currently supports apostrophes in the path, such as:
http://foo.com/blah_blah_I'm_king
However, there is no support for apostrophes followed by punctuation. This link is not found by linkify-it:
https://odysee.com/@EatMoreVegans:4/can-chefstemp-knock-thermoworks':0
What's happening here is that Odysee generates links using the first part of video titles. The title of the video linked above is "Can ChefsTemp Knock ThermoWorks' Thermapen One Off the Throne?". Their logic happens to end the path with the
'in the video title followed by punctuation.Services that includes unencoded apostrophes in paths could follow that apostrophe with a number of different characters. Here's a Google Cache link that follows an unencoded
'with a(.http://webcache.googleusercontent.com/search?q=cache:jkWRWOTPZXwJ:app.searchenabler.com/experiments/unsafe/%20!$&'()*+,-.:;%3C=%3E@[%5C]%5E_%60%7B%7C%7D~ &cd=1&hl=en&ct=clnk
All three of these links are supported by my changes.