Logging: Replace @hibas123/nodelogging with winston logger #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrick-Remy
changed the title
Patrick-Remy
force-pushed
the
winston-logger
branch
from
41b765b
to
6ef9967
Compare
|
Can you please merge the PR? As I think this is the only thing missing in this package, to be sort of usable as a dependency. I want to publish a homebridge package that relies on this package. But that isn't possible, as long as the previous logger is used, which is not configurable and creates unwanted files. |
|
Hi, thanks for the PR and sorry for the delay. Will test it soon and release/publish if okay. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this package is extremely verbose by default, and writes to /tmp files and console by default. This PR replaces the previously included, but rarely popular logging lib
nodeloggingby the widely-used libwinston. Also it adjusts log levels, to have fine-grained control over the output (now varies from debug, over silly and verbose to info).The previous
verboseproperty in the option is replaced bylogto override and customize any logging behaviour. The simplest is to override log-level to e.g.error.or disable any outputs
This resolves #24, #23 and #18.
Also the PR #19 can be closed after merging this.