Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in kwargs typehint for AvroBaseModel.fake #340

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

ddevlin
Copy link
Contributor

@ddevlin ddevlin commented Jun 8, 2023

For arbitrary argument lists, only the value type is required, using Dict[str, Any] here was interpreted as Dict[str, Dict[str, Any]].

For arbitrary argument lists, only the value type is required, using Dict[str, Any] here was interpreted as Dict[str, Dict[str, Any]].
@ddevlin
Copy link
Contributor Author

ddevlin commented Jun 13, 2023

@marcosschroh Sorry, I didn't spot that that was the last usage of typing.Dict, ready for re-testing.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #340 (b308df6) into master (50c95b1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #340    /-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          16       16           
  Lines        1293     1293           
  Branches      254      254           
=======================================
  Hits         1282     1282           
  Misses          3        3           
  Partials        8        8           
Impacted Files Coverage Δ
dataclasses_avroschema/avrodantic.py 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

@marcosschroh marcosschroh merged commit 8455a3f into marcosschroh:master Jun 13, 2023
@ddevlin ddevlin deleted the patch-1 branch June 13, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants