Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Theme selector that outlines the current theme #57

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

hansaskov
Copy link

No description provided.

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for astrofy-template ready!

Name Link
🔨 Latest commit 14a4c72
🔍 Latest deploy log https://app.netlify.com/sites/astrofy-template/deploys/65a7eca93bb11000083d89e2
😎 Deploy Preview https://deploy-preview-57--astrofy-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for astro-modern-personal-website ready!

Name Link
🔨 Latest commit 14a4c72
🔍 Latest deploy log https://app.netlify.com/sites/astro-modern-personal-website/deploys/65a7eca9ce32a40008ecdcff
😎 Deploy Preview https://deploy-preview-57--astro-modern-personal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hansaskov
Copy link
Author

hansaskov commented Jan 17, 2024

I have used your project for my personal use cases and spend some time to improve upon the theme selector. The changes are as follows:

  • The current theme is now shown with an outline

  • Added a fill to the theme svg. This is done because there would be cases where text could be seen through the icon at medium screen sizes

  • Cleaned up code by mapping over all the themes instead of hard coding each one

@hansaskov
Copy link
Author

@manuelernestog What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants