Introduce security token and bind to 127.0.0.1 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The original discussion was on issue #45. |
|
👍 LGTM thanks for the heads up, I'll make sure to release an update for |
|
Implementation-wise: you don't need to bring in an external dependency that fundamentally does the same thing you should, but for a totally different purpose. |
|
@moll Good point. Was too lazy there. |
mantoni
force-pushed
the
issue-45-secutiry
branch
from
09696bd
to
c929303
Compare
mantoni
added a commit
that referenced
this pull request
Jul 25, 2016
|
Released in v4.0.1 and v3.1.2. |
josephfrazier
added a commit
to josephfrazier/prettier_d
that referenced
this pull request
Jan 8, 2018
The server already listened on `127.0.0.1`, so we need to make sure the client does too. Related to mantoni/eslint_d.js#46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a security token that is generated on server startup and is stored along with the port number in
~/.eslint_d. Each request has to prepend the token, separated by a blank from the remaining payload. Requests without a matching token will be ignored.While this is a security fix, I am tempted to release this as a patch. However, at the same time this introduces a protocol break which will cause issues with eslintme. Fortunately, eslintme did not upgrade to
3.xor4.xyet, so it should not cause any damage. I don't know of anybody else using the wire protocol.Please send your feedback on this @moll and @ruyadorno. Thanks.