Make package release dates reproducible #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `string(TIMESTAMP ...)` respects `SOURCE_DATE_EPOCH` since CMake 3.8, which makes it possible to fix the date used as release date in AppStream metadata and Fedora packaging.
|
Thanks - I guess the in-tree distro packaging can also be removed if there is a downside keeping it. Indeed also for Fedora and OpenSuse the specs are managed separately in the respective build environments. |
|
coming from openSUSE: For .spec files, it does not hurt, if they are also in git / tar. It can even help in packaging when updates require changes to the .spec file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
string(TIMESTAMP ...)respectsSOURCE_DATE_EPOCHsince CMake 3.8, which makes it possible to fix the date used as release date in AppStream metadata and Fedora packaging.I didn"t change the PACKAGE_RFC_DATE as %z was anlyadded in CMake 3.26 and I didn"t want to raise the required CMake version. Might be an option to just remove the in-tree Debian packaging finally?