Elogind changes #687
Open
Elogind changes #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't implement cgroups at this moment, and elogind can work without it. Still, it seems to check /proc/[pid]/cgroup, so stub it with reasonable values.
no92
reviewed
Jun 29, 2024
| @@ -178,6 178,15 @@ int main() { | |||
| }else assert(dbus != -1); | |||
| } | |||
|
|
|||
| // Launch elogind if it's available. | |||
| if(!access("/usr/lib/elogind/elogind", X_OK)) { | |||
| sleep(5); // Wait for dbus to be fully started, this is a hack. | |||
There was a problem hiding this comment.
It would be nice to either get InitWare working soon™ or figure out what heuristic we can use for detecting dbus-daemon activation.
There was a problem hiding this comment.
Agreed. I should retry that soon
| @@ -178,6 178,15 @@ int main() { | |||
| }else assert(dbus != -1); | |||
| } | |||
|
|
|||
| // Launch elogind if it's available. | |||
| if(!access("/usr/lib/elogind/elogind", X_OK)) { | |||
There was a problem hiding this comment.
There doesn't seem to be an elogind port upstream or PRed in yet?
There was a problem hiding this comment.
That's correct, but there's no reason to not add it now with the port coming hopefully soon. It's just a matter of cleaning it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an auto launch of elogind if it's installed, and adds some required items (mostly workarounds) on the Managarm side. As a bonus, logging was improved for not implemented file operations.