Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing to pull requests results in unrendered HTML on Gitlab forges #318

Open
Thaodan opened this issue Dec 8, 2020 · 13 comments
Open
Labels
area: gitlab bug upstream An upstream bug we have to live with

Comments

@Thaodan
Copy link

Thaodan commented Dec 8, 2020

When pushing a new commit to a repository there is a new message about the new commit eg in my latest case:

Thaodan 2 hours ago
added 1 commit

<ul><li>f3846f73 - [sb2] Refactor path handling. Contributes to
JB#51819</li></ul>

This that intended or a bug?
My forge version is: 20201201.1713

@tarsius
Copy link
Member

tarsius commented Dec 8, 2020

When pushing a new commit to a repository there is a new message about the new commit eg in my latest case:

Either I completely misunderstand what you are talking about or this has nothing to do with Forge. Forge has no say in what Gitlab.com does in response to you effectively running git pull .... If this is actually what you are talking about, then explain why you think Forge has anything to do with it.

@Thaodan
Copy link
Author

Thaodan commented Dec 8, 2020 via email

@Thaodan
Copy link
Author

Thaodan commented Dec 8, 2020

Screenshot_20201209_003507

@tarsius
Copy link
Member

tarsius commented Dec 8, 2020

That's certainly unexpected and I've never seen it before. Does that happen just with the gitlab instance we talked about before or also on gitlab.com?

@Thaodan
Copy link
Author

Thaodan commented Dec 9, 2020 via email

@tarsius
Copy link
Member

tarsius commented Dec 9, 2020

Actually I just remembered that this is a feature. I didn't remember before because I don't really use Forge with Gitlab. This was "implemented" in b019dfa.

@tarsius
Copy link
Member

tarsius commented Dec 9, 2020

The <ul><li> part is new, I believe. Or maybe adding a commit did not result in the creation of what the Gitlab API calls a "note".

In any case this is rather noisy and we should probably filter out some of that text. But I am not thrilled about the prospect of having to use some heuristic again to guess the type of a "note" (see the comment removed by the mentioned commit). So I probably won't tackle this any time soon.

@tarsius tarsius added bug third-party Bug in third-party that we have to work around bug upstream An upstream bug we have to live with and removed bug third-party Bug in third-party that we have to work around labels Dec 9, 2020
@tarsius
Copy link
Member

tarsius commented Dec 9, 2020

Classifying as a "upstream bug" because they really should have a type field on the very generic "note" object type.

@Thaodan
Copy link
Author

Thaodan commented Dec 9, 2020 via email

@tarsius
Copy link
Member

tarsius commented Dec 9, 2020

I agree, these "notes" are useful, but what would be even better is if we could easily tell them apart from comments that were written by human beings. We could then provide different functionality depending on the type of the "note" at point. For example, we could disallow editing "status updates". It is currently possible to attempt to do so; of course it eventually leads to an error, but unfortunately not upfront.

@Thaodan
Copy link
Author

Thaodan commented Dec 9, 2020

Reported the problem upstream:
https://gitlab.com/gitlab-org/gitlab/-/issues/292422

@Thaodan
Copy link
Author

Thaodan commented Dec 9, 2020

Feel free to ad more if I had missed something.

@tarsius
Copy link
Member

tarsius commented Jun 13, 2022

So far they have talked about who's responsibility it is to look into this. 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: gitlab bug upstream An upstream bug we have to live with
Projects
None yet
Development

No branches or pull requests

2 participants