Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for GitHub teams as reviewers #304

Open
xendk opened this issue Nov 12, 2020 · 1 comment
Open

Allow for GitHub teams as reviewers #304

xendk opened this issue Nov 12, 2020 · 1 comment
Labels
area: github enhancement New feature or request

Comments

@xendk
Copy link

xendk commented Nov 12, 2020

GitHub allows for requesting review from an organization team, which is a way to ask for review from anyone in a group. We have a bot that picks up on this and posts a message to our Zulip chat.

But it doesn't seem to work in forge. If I manually type out reload/developers, and press return an extra time to confirm it, forge seems to have accepted it and done something, but it doesn't show up on the PR.
@tarsius tarsius added the enhancement New feature or request label Nov 13, 2020
@danomeerf
Copy link

I second this request as our standard practice (with GitHub) is to set as Reviewers a list of people maintained in the group <organization>/pull-request-reviewers. As it stands now I either have to add them individually in Forge from memory (not that the list changes that often) or browse to the PR in GitHub and set the group there. Entering the group name in Forge seems to do nothing and no error is indicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: github enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tarsius @xendk @danomeerf