Fix typing_extensions import handling for mypy

mypy can handle `if sys.version_info` checking better than `try ... except ImportError`. This is somewhat disappointing, but the rewrite of these import lines isn't that bad and aligns with the recommendations of the mypy docs.
madhuri22121 · Jan 5, 2022 · a8c131b · a8c131b
1 parent 5a2f8ee
commit a8c131b
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/jsonschema/protocols.py b/jsonschema/protocols.py
@@ -6,10  6,18 @@
 #   https://www.python.org/dev/peps/pep-0544/
 
 from typing import Any, ClassVar, Iterator, Optional, Union
 import sys
 
-try:
 # doing these imports with `try ... except ImportError` doesn't pass mypy
 # checking because mypy sees `typing._SpecialForm` and
 # `typing_extensions._SpecialForm` as incompatible
 #
 # see:
 # https://mypy.readthedocs.io/en/stable/runtime_troubles.html#using-new-additions-to-the-typing-module
 # https://github.com/python/mypy/issues/4427
 if sys.version_info >= (3, 8):
     from typing import Protocol, runtime_checkable
-except ImportError:
 else:
     from typing_extensions import Protocol, runtime_checkable
 
 from jsonschema._format import FormatChecker