Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pe: parse pkcs7 Content in certificate table #360

Closed
wants to merge 2 commits into from

Conversation

baloo
Copy link
Contributor

@baloo baloo commented Mar 10, 2023

No description provided.

@baloo baloo marked this pull request as draft March 10, 2023 22:51
@RaitoBezarius
Copy link
Contributor

You should add a mention to the README for this new flag.

@RaitoBezarius RaitoBezarius mentioned this pull request Mar 11, 2023
25 tasks
@baloo baloo force-pushed the baloo/parse-pkcs7-content branch from 2f74a20 to e197def Compare March 12, 2023 03:38
@baloo baloo marked this pull request as ready for review March 12, 2023 03:38
@baloo baloo force-pushed the baloo/parse-pkcs7-content branch from e197def to 0f65832 Compare March 12, 2023 03:40
@m4b
Copy link
Owner

m4b commented Mar 13, 2023

Hmmm, I wasn't aware you had plans to add these dependencies to goblin. So in general, this crate is extremely conservative when it comes to dependencies, and none have been added for about 4-5 years, and the ones it does have I'm in control of or will never change, like adding more dependencies (or if it does, i'll just delete the dep, e.g. plain). It's going to take some good convincing why this needs to be in goblin itself, and why the user can't just call this function themselves on the raw bytes. In general, for more sophisticated structures like this, in this crate I've generally sided on the fact that it's not goblin's job to parse this unless it has to. And in this PR I don't see any reason why it has to (e.g., the user can just call this).
Anyway, that's the general stance, apologies in advance if that's disappointing :)

@m4b m4b mentioned this pull request Mar 13, 2023
@baloo
Copy link
Contributor Author

baloo commented Mar 13, 2023

This is less of an issue here than it is in #358 I'll reply there

@baloo
Copy link
Contributor Author

baloo commented Mar 13, 2023

Can implement this in a sub-crate. Let me know if you want to get involved, or retain control over such a subcrate.

@baloo baloo closed this Mar 13, 2023
@baloo baloo deleted the baloo/parse-pkcs7-content branch May 5, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants