Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Metric type controls in AggregateTilesOptions #3743

Merged
merged 7 commits into from
Sep 15, 2021

Conversation

linasm
Copy link
Collaborator

@linasm linasm commented Sep 14, 2021

What this PR does / why we need it:
Add some new settings to AggregateTilesOptions.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:
NONE

Does this PR require updating code package or user-facing documentation?:
NONE

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #3743 (b659f01) into master (b659f01) will not change coverage.
The diff coverage is n/a.

❗ Current head b659f01 differs from pull request most recent head 3c07cee. Consider uploading reports for the commit 3c07cee to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3743    /-   ##
======================================
  Coverage    56.9%   56.9%           
======================================
  Files         552     552           
  Lines       63627   63627           
======================================
  Hits        36234   36234           
  Misses      24163   24163           
  Partials     3230    3230           
Flag Coverage Δ
aggregator 63.1% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 58.4% <0.0%> (ø)
dbnode 60.5% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.7% <0.0%> (ø)
msg 74.3% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b659f01...3c07cee. Read the comment docs.

@linasm linasm merged commit 5a34ba4 into master Sep 15, 2021
@linasm linasm deleted the linasm/metric-type-controls-in-aggregate-tiles-options branch September 15, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants