Support Promremotebench Metrics && Add Monitoring Dash #2131
Conversation
| - apiVersion: v1 | ||
| data: | ||
| m3db_node_details.json: |- | ||
| { |
There was a problem hiding this comment.
Is there a way we can pull this out into a separate json representation of the dash and include that here instead?
There was a problem hiding this comment.
I don't think so, I couldn't find anything. It looks like this is the way to do it if we write out the yamls ourselves.
Although it seems like using kubectl you can create config maps from files with a flag.
There was a problem hiding this comment.
Maybe even just as part of a build step that will swap out a template var for the dash json or something?
There was a problem hiding this comment.
We could prob use perl or sed but I think it's too much for these test dash defs.
All other dash are also defined in the same way in the file.
Codecov Report
@@ Coverage Diff @@
## master #2131 /- ##
=========================================
Coverage 59.1% 72.3% 13.1%
=========================================
Files 1012 1012
Lines 133969 87092 -46877
=========================================
- Hits 79298 63020 -16278
Misses 48451 19860 -28591
Partials 6220 4212 -2008
Continue to review full report at Codecov.
|
What this PR does / why we need it:
Adds prom deployment to promremotebench server and adds a monitoring dash for both m3db node and promremotebench.
Also increases prom retention to 48h.
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: