Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbnode] Use zero sized pools in test and move big tests to regular tests #2094

Merged
merged 2 commits into from
Jan 5, 2020

Conversation

robskillington
Copy link
Collaborator

What this PR does / why we need it:

Looks like the pools created from the tools package is very heavy, removing this pool usage in tests.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:


Does this PR require updating code package or user-facing documentation?:


@codecov
Copy link

codecov bot commented Jan 5, 2020

Codecov Report

Merging #2094 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2094    /-   ##
======================================
  Coverage    72.3%   72.3%           
======================================
  Files        1007    1007           
  Lines       86414   86414           
======================================
  Hits        62555   62555           
  Misses      19682   19682           
  Partials     4177    4177
Flag Coverage Δ
#aggregator 82% <0%> (ø) ⬆️
#cluster 85.6% <0%> (ø) ⬆️
#collector 64.8% <0%> (ø) ⬆️
#dbnode 79.7% <0%> (ø) ⬆️
#m3em 73.2% <0%> (ø) ⬆️
#m3ninx 73.9% <0%> (ø) ⬆️
#m3nsch 51.1% <0%> (ø) ⬆️
#metrics 17.6% <0%> (ø) ⬆️
#msg 74.7% <0%> (ø) ⬆️
#query 68.4% <0%> (ø) ⬆️
#x 83.1% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cd41e0...d4ddc0e. Read the comment docs.

@robskillington robskillington merged commit 8d833bc into master Jan 5, 2020
@robskillington robskillington deleted the r/remove-big-tests branch January 5, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants