Update links to language models in README #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-bain this PR 757 from @MJochim seems to me to supercede PR #522 (which simply changes the README list of language codes.) and instead it directs people to look at the code for the HF related models. That's probably a bit less repo-browser / user-friendly than updating a full language code list, but is may be more sustainable for README accuracy and developer helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of languages is no longer in transcribe.py, it’s been moved to alignment.py. I have created a new permalink.
I would suggest another change: remove
from line 141. It seems to work with
--model smalljust as well. But I am not sure why it was there in the first place, so I haven’t included the change in this PR.