Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making tabs reorderable #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SauronfromMordor
Copy link
Contributor

No description provided.

@mtasaka
Copy link
Contributor

mtasaka commented May 4, 2018

I tried this patch and it seems to be working. This is a nice feature and I will be glad if this patch is merged :-)

@davesp
Copy link
Contributor

davesp commented Aug 10, 2018

In "lxterminal 0.3.1", I can drag-and-drop tabs to re-order them. Would this change affect anything?

@mtasaka
Copy link
Contributor

mtasaka commented Aug 12, 2018

Well, I cannot reorder tabs on 0.3.1 (compiled with GTK2) without this patch. I guess the patch author actually cannot reorder, either.

@davesp
Copy link
Contributor

davesp commented Aug 13, 2018

My earlier test seems to have been faulty; after re-testing with the baseline, I can re-order tabs with shortcut keys but not with the mouse. With this patch, I can re-order tabs with the mouse.

@medicalwei
Copy link
Contributor

medicalwei commented Aug 18, 2018

After reordering, the terminal->terms doesn't properly reindexed (see terminal_move_tab_execute). I am wondering if we shouldn't make such array keep tracking the terminals but extend the underlying GtkBox to accommodate term structure.

@medicalwei medicalwei self-requested a review August 18, 2018 01:58
@mtasaka
Copy link
Contributor

mtasaka commented Aug 27, 2018

After reordering, the terminal->terms doesn't properly reindexed

Just a thought: there is "page-reordered" signal, so perhaps we can do what is written in terminal_move_tab_execute when this signal is emitted (but some modification will be needed)

@FinboySlick
Copy link
Contributor

After reordering, the terminal->terms doesn't properly reindexed (see terminal_move_tab_execute). I am wondering if we shouldn't make such array keep tracking the terminals but extend the underlying GtkBox to accommodate term structure.

I had actually started working on this a while back. If I recall, my approach was to get rid of our list of term objects and instead manage it through the gtk objects themselves (Which would re-order automatically). It was a lot of re-writing and testing though and sadly fell on the wayside. It is definitely something I planned to implement however.

@itsdonnix
Copy link

Fixes #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants