-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making tabs reorderable #50
base: master
Are you sure you want to change the base?
Conversation
I tried this patch and it seems to be working. This is a nice feature and I will be glad if this patch is merged :-) |
In "lxterminal 0.3.1", I can drag-and-drop tabs to re-order them. Would this change affect anything? |
Well, I cannot reorder tabs on 0.3.1 (compiled with GTK2) without this patch. I guess the patch author actually cannot reorder, either. |
My earlier test seems to have been faulty; after re-testing with the baseline, I can re-order tabs with shortcut keys but not with the mouse. With this patch, I can re-order tabs with the mouse. |
After reordering, the |
Just a thought: there is "page-reordered" signal, so perhaps we can do what is written in |
I had actually started working on this a while back. If I recall, my approach was to get rid of our list of term objects and instead manage it through the gtk objects themselves (Which would re-order automatically). It was a lot of re-writing and testing though and sadly fell on the wayside. It is definitely something I planned to implement however. |
Fixes #73 |
No description provided.