Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix include path of lvgl.h #6050

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix include path of lvgl.h #6050

merged 1 commit into from
Apr 12, 2024

Conversation

cheops
Copy link
Contributor

@cheops cheops commented Apr 9, 2024

fix compilation error lvgl/src/font/lv_font_simsun_14_cjk.c:10:14: fatal error: lvgl/lvgl.h: No such file or directory

lvgl/src/font/lv_font_simsun_14_cjk.c:10:14: fatal error: lvgl/lvgl.h: No such file or directory
   10 |     #include "lvgl/lvgl.h"
      |              ^~~~~~~~~~~~~

looking at the other font files, the include path in this file is wrong.
Compilation succeeds after the change.
Compiled from https://github.com/kdschlosser/lvgl_micropython

liamHowatt
liamHowatt approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@liamHowatt liamHowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is how the correct header is automated. Easy to miss if the font isn't generated with this generate_all.py script.

lvgl/scripts/built_in_font/generate_all.py

Line 89 in 500e16e

os.system('sed -i \'s|#include "lvgl/lvgl.h"|#include "../../lvgl.h"|\' lv_font_*.c')

@liamHowatt liamHowatt mentioned this pull request Apr 10, 2024
Closed
kisvegabor
kisvegabor approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kisvegabor kisvegabor merged commit a28ddae into lvgl:master Apr 12, 2024
16 checks passed
@cheops cheops deleted the patch-1 branch April 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisvegabor kisvegabor kisvegabor approved these changes

@W-Mai W-Mai W-Mai approved these changes

@FASTSHIFT FASTSHIFT FASTSHIFT approved these changes

@liamHowatt liamHowatt liamHowatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cheops @kisvegabor @W-Mai @FASTSHIFT @liamHowatt