feat(demos): align images used in benchmark to stride 64 #5925
Conversation
cristian-stoica
force-pushed
the
update-image-assets-to-satisfy-stride_64
branch
4 times, most recently
from
4a5b25a
to
eb69fce
Compare
| #endif | ||
|
|
||
| #ifndef LV_ATTRIBUTE_IMAGE_IMG_COGWHEEL_ARGB | ||
| #define LV_ATTRIBUTE_IMAGE_IMG_COGWHEEL_ARGB | ||
| #ifndef LV_ATTRIBUTE_IMG_DUST |
There was a problem hiding this comment.
@anaGrad I see all the files have been changed with this define.
I suppose this is a python script effect, please have it fixed all over.
Thanks.
There was a problem hiding this comment.
Is there any convention on the naming of the images?
-
I notice there is an inconsistency in the names (for example, in the assets of widgets, some images have widget in the name, others don't).
-
The names of the .c files is different from that of the .png file (for example in benchmark/assets).
-
There are multiple pngs with different names in different folders for what looks like the same image and I was wondering why is it like that (example: lvgl logo in demo/render vs demo/widgets)
There was a problem hiding this comment.
I don't understand neither. It's used in all old .c images and I simply copied the original headers as template to python script.
There was a problem hiding this comment.
The name of the image should be used in the ATTRIBUTE name. See this from v8.3.
The names are really not consistent now. We can work on that too in an other PR.
There was a problem hiding this comment.
Yes, that ATTRIBUTE has been fixed.
We will address separately the naming files .png vs .c It really has to be a consistency and avoid duplication.
Signed-off-by: Ana Grad <[email protected]>
cristian-stoica
force-pushed
the
update-image-assets-to-satisfy-stride_64
branch
from
eb69fce
to
cdd982c
Compare
|
@XuNeo What is the endians rule for this script for index formats? As a matter of fact, LVGL is all over little endian fashion, right? So it should be the script acting. |
|
Yes. Little endian is used. https://github.com/lvgl/lvgl/blob/master/scripts/LVGLImage.py#L22-L39 |
|
My question is inside the byte, what is the order for index format type? |
|
For indexed image, lvgl/src/libs/bin_decoder/lv_bin_decoder.c Lines 1035 to 1043 in 03498a2 The LVGLImage.py uses |
|
OK, so according to this picture the python script generate a VG_LITE_INDEX_ENDIAN_BIG_ENDIAN. |
|
The endianes format for index format can be addressed later, if everything is fine with the c array files, you can merge them to master. |
FASTSHIFT
changed the title
|
There was no python script changes. Just the new images aligned. |
Let's update the script separately than. |
Description of the feature or fix
A clear and concise description of what the bug or new feature is.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.10 needs to be installed) and follow the Code Conventions.