fix(rtthread): implement lv_strcat function in rt-thread due to absence of rt_strcat #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FASTSHIFT
previously approved these changes
Mar 20, 2024
FASTSHIFT
changed the title
XuNeo
reviewed
Mar 20, 2024
|
Based on this issue we should have |
Should I turn off my pr? Because I thought that when @liamHowatt was updated, the problem I solved with this pr should have been fixed. Or do I add the lv_strncat function directly to this pr? @kisvegabor |
XuNeo
reviewed
Mar 20, 2024
XuNeo
changed the title
…ce of rt_strcat Signed-off-by: lhdjply <[email protected]>
|
Here is the PR #5927 |
liamHowatt
added a commit
to liamHowatt/lvgl
that referenced
this pull request
Mar 20, 2024
XuNeo
approved these changes
Mar 24, 2024
FASTSHIFT
approved these changes
Mar 26, 2024
FASTSHIFT
approved these changes
Mar 26, 2024
|
Thank you all for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
fix(warning): fix the issue of lv_string_rtthread prompting for the lack of strcat
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.10 needs to be installed) and follow the Code Conventions.