Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(music): fix image display errors in 16 bit and 24 bit errors #5291

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix(music): fix image display errors in 16 bit and 24 bit errors #5291

merged 1 commit into from
Jan 12, 2024

Conversation

lhdjply
Copy link
Contributor

@lhdjply lhdjply commented Jan 12, 2024

Help us review this PR! Anyone can approve it or request changes.

Description of the feature or fix

fix #5173
fix(music): fix image display errors in 16 bit and 24 bit errors

Checkpoints

@IAMMX
Copy link
Contributor

IAMMX commented Jan 12, 2024

Cool,I tested it and indeed fixed the issue. Thanks

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
FYI,

  • Using ARGB8888 in case of 16 bit target color format is slower
  • The jumping bars of the music player are still ugly.

Anyway, at least it works now! ❤️

@kisvegabor kisvegabor merged commit ff9e63a into lvgl:master Jan 12, 2024
16 checks passed
@lhdjply lhdjply deleted the fix_music branch January 13, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The demo lv_demo_music shows an exception when the color is 24 bits or 16 bits
4 participants