Dave2d rgb565a8 image support #5200
Conversation
| @@ -100,6 100,7 @@ d2_u32 lv_draw_dave2d_lv_colour_fmt_to_d2_fmt(lv_color_format_t colour_format) | |||
|
|
|||
| switch(colour_format) { | |||
| case(8): | |||
There was a problem hiding this comment.
8 means LV_COLOR_FORMAT_I2 . I think it's incorrect.
There was a problem hiding this comment.
I have updated the pull request, removing the case(8)
| #if defined(RENESAS_CORTEX_M85) | ||
| #if (BSP_CFG_DCACHE_ENABLED) | ||
| d1_cacheblockflush(u->d2_handle, 0, src_buf, | ||
| img_stride * decoder_dsc->header.h); //Stride is in bytes, not pixels/texels |
There was a problem hiding this comment.
Can we use decoded->data_size directly?
There was a problem hiding this comment.
When I look at the value of decoded->data_size for an RGB656A8 image, it's value is 0, so I cannot use it.
There was a problem hiding this comment.
Hi,
Can you debug into it to see why it's zero?
Is a C-array image used for test? I know current C-array images in examples, and demos are lack of data_size field. Those images needs to be regenerated.
There was a problem hiding this comment.
I am using the Widgets demo to test this, one of the demos is the first thing a customer will run when thry try LVGL on the RA8D1 using the Dave2D
There was a problem hiding this comment.
I have created #5205 to track the issue. We should update the image resources.
|
|
||
| lv_point_t p1[4] = { //Points in clockwise order | ||
| {0, 0}, | ||
| {decoder_dsc->header.w - 1, 0}, |
There was a problem hiding this comment.
We should use decoded->header instead. Same for below. The decoded image may differ with original image. For example, software renderer doesn't support I1/2/4/8, thus decoder will convert to ARGB8888.
There was a problem hiding this comment.
I have update the pull request, to use decoded->header
There was a problem hiding this comment.
I merge it now.
We can have follow up PRs when #5205 is resolved.
Help us review this PR! Anyone can approve it or request changes.
Description of the feature or fix
[FEAT] Add support for Dave2D to draw RGB565A8 images
A clear and concise description of what the bug or new feature is.
Checkpoints
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle needs to be installed) and follow the Code Conventions