Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo in a table field name #689

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

Bilal2453
Copy link
Contributor

@Bilal2453 Bilal2453 commented Jan 17, 2024

the field name is no_truncate not no_trunate, it is correctly defined in the code.

I think the true|false format is also inconsistent, it will make things harder when generating the docs, should simply be something like { no_truncate: boolean }, or the more consistent

`flags`:
   `no_truncate`: `boolean`

update:
There is also a new **Note** format that was introduced with 8e2f306.
But maybe I will tackle those later when I progress with https://github.com/Bilal2453/luv-docgen.

Copy link
Member

@squeek502 squeek502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@squeek502 squeek502 merged commit a0ddec2 into luvit:master Jan 17, 2024
14 checks passed
Bilal2453 added a commit to Bilal2453/luvit-meta that referenced this pull request Jan 17, 2024
@Bilal2453 Bilal2453 deleted the patch-4 branch January 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants