Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for Node.js v18.6.0 #37

Merged
merged 6 commits into from
Jul 19, 2022
Merged

fix: add support for Node.js v18.6.0 #37

merged 6 commits into from
Jul 19, 2022

Conversation

antongolub
Copy link
Contributor

@antongolub antongolub changed the title fix: add support for Node.js v18.6.8 fix: add support for Node.js v18.6.0 Jul 16, 2022
@antongolub
Copy link
Contributor Author

antongolub commented Jul 16, 2022 •
edited
Loading

btw, esbuld >= 0.14.32 breaks tsc buld.

lukeed
lukeed reviewed Jul 18, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
lukeed
lukeed requested changes Jul 18, 2022
View reviewed changes
src/loader.ts Outdated Show resolved Hide resolved
@lukeed
Copy link
Owner

lukeed commented Jul 18, 2022

Why they didn't add this flag with a true default value is beyond me. So annoying... intra-version breaking change. Node team continues to ace the ESM rollout 🙄

@antongolub
Copy link
Contributor Author

antongolub commented Jul 18, 2022 •
edited
Loading

ESM is our python3-like frustrative challenge)

@lukeed, Do you know what is returnd by fallback?
Should we use return Object.assign(await fallback(...), {shortCircuit: true}) or return fallback(...) would be enough?

@antongolub antongolub requested a review from lukeed July 18, 2022 08:48
antongolub added a commit to semrel-extra/zx-bulk-release that referenced this pull request Jul 18, 2022
@antongolub
ci: pin nodejs to v18.5
3ba07db 
lukeed/tsm#37
lukeed
lukeed reviewed Jul 19, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
lukeed
lukeed approved these changes Jul 19, 2022
View reviewed changes
Copy link
Owner

@lukeed lukeed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling fallback invokes/passes off to native behavior, so whatever the normal hook would have done will/should be done. But at this point who knows anymore

Thanks for PR and the iterations~!

@lukeed lukeed merged commit 82c0e90 into lukeed:master Jul 19, 2022
antongolub added a commit to antongolub/action-setup-bun that referenced this pull request Jul 22, 2022
@antongolub
ci: update tsm to v2.2.2 to fix nodejs 18.6 issue, reset node v to 18
d025133 
lukeed/tsm#37
@antongolub antongolub mentioned this pull request Jul 22, 2022
Merged
2 tasks
antongolub added a commit to antongolub/action-setup-bun that referenced this pull request Jul 22, 2022
@antongolub
ci: update tsm to v2.2.2 to fix nodejs 18.6 issue, reset node v to 18
1d8e9ec 
lukeed/tsm#37
This was referenced Sep 13, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeed lukeed lukeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERR_LOADER_CHAIN_INCOMPLETE on Node.js 18.6
2 participants
@antongolub @lukeed