LDEV-4866 fix query parser out of bounds (6.2) take 2 #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspitzer
changed the title
|
|
||
| // handle single line comment | ||
| if (c == '-' && i < (sqlLen - 1) && sql.charAt(i 1) == '-') { | ||
| int end = sql.indexOf('\n', i 1); |
There was a problem hiding this comment.
does not handle if the comment is at the last line of the SQL
| if ( i < (sqlLen - 1)) { | ||
| // handle multi line comment | ||
| if (c == '/' && sql.charAt(i 1) == '*') { | ||
| int end = sql.indexOf("*/", i 2); |
There was a problem hiding this comment.
you don't handle at all if the multi line or single line comment is within a literal string like
select '/* multi */ // -- single' as comments, that actually is the most complicated part about parsing, be aware of the current context ans switch between them. This also reinvents the wheel for code we already have in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://luceeserver.atlassian.net/browse/LDEV-4866
refiled from #2382 against 6.2