Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]Baudrate not updating #975

Closed
dbuezas opened this issue Dec 3, 2023 · 3 comments
Closed

[BUG]Baudrate not updating #975

dbuezas opened this issue Dec 3, 2023 · 3 comments
Labels
bug ESP-3.X Fixed outdated

Comments

@dbuezas
Copy link

dbuezas commented Dec 3, 2023

Describe the bug

I set it to 500000, saved and restarted
image

To Reproduce

  1. Go to UI
  2. Increase to 500000
  3. Save, restart

ESP3D Firmware:

  • ESP3D FW version: v3/Refactoring-internal-clients/c7957a2fe1068446fdbab6302314e3a1f155ef32
  • ESP3D-WebUI Version: v3
  • Wifi mode: Client
  • Flash method: PlatformIO]
  • Any change done in FW:

Board used (please complete the following information):

  • MCU: ESP8266 ESP-12s
  • Name: BTT wifi board
  • Flash size: 4MB

Additional context

It also doesn't actually change the baud rate, it stays at 115200
@dbuezas dbuezas added the bug label Dec 3, 2023
@luc-github
Copy link
Owner

luc-github commented Dec 4, 2023 •
edited
Loading

I will have a look today, I can duplicate issue
It seems change is well applied but not reflected even chacking with [ESP901]
so issue is in FW definitly - change fully ok if only use [ESP901] so issue should be in [ESP401]

luc-github added a commit that referenced this issue Dec 4, 2023
@luc-github
Fix #975 thanks to @dbuezas
f33f711
@luc-github
Copy link
Owner

luc-github commented Dec 4, 2023 •
edited
Loading

Fixed - had 2 issues actually : wrong validation Fn (bad copy and paste when did the rewrite) and the error of not saving was not raised

Thank you for rasing it ^_^

@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug ESP-3.X Fixed outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbuezas @luc-github