Switch arg parsing to clap v4 with derive #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tranzystorekk
force-pushed
the
clap-derive
branch
from
00a40e3
to
2d01c90
Compare
Codecov Report
@@ Coverage Diff @@
## master #818 /- ##
==========================================
Coverage 86.57% 87.35% 0.78%
==========================================
Files 44 44
Lines 4507 4272 -235
==========================================
- Hits 3902 3732 -170
Misses 605 540 -65
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
hi @tranzystorek-io, thanks so much for sending this big PR! I have glanced at it mostly, and it lgtm in a glance. @meain what do you think about upgrading to v4, if you have not other concern we can play some attention on this and done the migration |
|
Heh, sorry for submitting a large chunk of changes like that, I got slightly carried away once I started drafting the code |
tranzystorekk
force-pushed
the
clap-derive
branch
from
2d01c90
to
9eda599
Compare
|
@zwpaper If it looks good to you feel free you merge :D. |
|
I have checked most of the code, it mostly looks good to me, and I will test it locally and merge if no problems occurred |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make the code slightly more maintainable. Did my best to preserve old behavior, e.g. flags overriding themselves.
Notes:
TODO
cargo fmt