Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Fix: Add external mariaDB setup #3017

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Apr 3, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

  • External mariaDB does not check for existence of the database before connecting.
  • The User count check does not work on mariaDB.

Just from this little encounter, knex.js does not seem fun to use. Just getting the count requires such convoluted functions.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@louislam louislam added this to the 2.0.0 milestone May 15, 2023
server/database.js Outdated Show resolved Hide resolved
Co-authored-by: Frank Elsinga <[email protected]>
@bt90
Copy link
Contributor

bt90 commented Jun 21, 2023

Any specific reason for choosing MariaDB? PostgreSQL might be a better fit because we can add TimescaleDB support down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants