Keep scroll position when reinstantiating science_report #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blabber
force-pushed
the
bugfix/science_report_scroll_position
branch
from
c459790
to
901acc0
Compare
|
All views are losing their state (scroll positions etc.), tracking and restoring them is possible, but I think we should take our time to check if we could restore the old behavior from stable (not destroying the instances). I am converting this into a draft PR for now. |
|
Notes:
|
blabber
force-pushed
the
bugfix/science_report_scroll_position
branch
from
901acc0
to
3bc16c3
Compare
|
@jwrober, I updated this PR with a version I used to play LT85 until now. This change does not destroy reports/views when the player switches to the map and thus retains their state. |
|
Looks like it needs a |
This reverts commit f985113. Calling the `popdown*' functions causes the destructors of the views to be called. As a result, the views lose their state. Reverting this commit may use a little extra memory as the views are kept in memory, but seems to have no other negative impact and restores the behaviour known from 3.0. Closes longturn#2329
blabber
force-pushed
the
bugfix/science_report_scroll_position
branch
from
3bc16c3
to
24e44b9
Compare
jwrober
approved these changes
Sep 7, 2024
This is because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
science_reportloses the scroll position when the view is closed. This is because the object is destroyed and therefore loses its state.This commit adds code to track the scroll position in static fields and restore the state when the
science_reportis reinstantiated.Closes #2329.
An alternative solution would be to prevent the destruction of
science_reportwhen the view is closed; this is the behavior in stable.