Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused feature macros #2115

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Remove unused feature macros #2115

merged 2 commits into from
Jan 1, 2024

Conversation

lmoureaux
Copy link
Contributor

I went through the process of evaluating all feature macros once again. The large number removed macros shows how much refactoring work has been happening since the last time we looked at this in 2020.

Closes #2103.

@lmoureaux lmoureaux requested a review from jwrober January 1, 2024 03:47
@lmoureaux lmoureaux marked this pull request as draft January 1, 2024 05:07
@lmoureaux
Copy link
Contributor Author

I removed FREECIV_TESTMATIC but it's used in log.h

@lmoureaux lmoureaux marked this pull request as ready for review January 1, 2024 22:05
@lmoureaux
Copy link
Contributor Author

I removed FREECIV_TESTMATIC but it's used in log.h

Converted it to a normal qInfo.

@jwrober jwrober merged commit 9d01830 into longturn:master Jan 1, 2024
21 checks passed
@lmoureaux lmoureaux deleted the refactor/fewer-defines branch January 1, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We define too many feature macros
2 participants
@lmoureaux @jwrober