Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Backup progress should not add block failed to upload to successful count #9791

Open
derekbit opened this issue Nov 12, 2024 · 2 comments
Open

[BUG] Backup progress should not add block failed to upload to successful count #9791

derekbit opened this issue Nov 12, 2024 · 2 comments
Assignees
@derekbit @roger-ryao
Labels
area/volume-backup-restore Volume backup restore backport/1.6.4 backport/1.7.3 kind/bug priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Milestone
v1.8.0

Comments

@derekbit
Copy link
Member

Describe the bug

The failure of block file upload is not captured by the err (source code), so the failed block will be added to successful count.

To Reproduce

Expected behavior

Support bundle for troubleshooting

Environment

  • Longhorn version:
  • Impacted volume (PV):
  • Installation method (e.g. Rancher Catalog App/Helm/Kubectl):
  • Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version:
    • Number of control plane nodes in the cluster:
    • Number of worker nodes in the cluster:
  • Node config
    • OS type and version:
    • Kernel version:
    • CPU per node:
    • Memory per node:
    • Disk type (e.g. SSD/NVMe/HDD):
    • Network bandwidth between the nodes (Gbps):
  • Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
  • Number of Longhorn volumes in the cluster:

Additional context

Workaround and Mitigation
@derekbit derekbit added kind/bug priority/0 Must be implement or fixed in this release (managed by PO) area/volume-backup-restore Volume backup restore require/qa-review-coverage Require QA to review coverage require/backport Require backport. Only used when the specific versions to backport have not been definied. backport/1.6.4 backport/1.7.3 labels Nov 12, 2024
@derekbit derekbit added this to the v1.8.0 milestone Nov 12, 2024
@derekbit derekbit self-assigned this Nov 12, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Longhorn Sprint Nov 12, 2024
This was referenced Nov 12, 2024
Open
Open
@derekbit
Copy link
Member Author

cc @ChanYiLin

@derekbit derekbit mentioned this issue Nov 12, 2024
Merged
@derekbit derekbit moved this from New Issues to Review in Longhorn Sprint Nov 12, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Nov 12, 2024 •
edited by derekbit
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  1. While backing up a volume to S3 storage, disconnect the network to the S3 storage
  2. The backup can be stopped and become error.
  3. Reconnect to network to s3 storage
  4. Back up the volume again
  5. Restore the backup and verify the data integrity

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/backupstore#209

  • Which areas/issues this PR might have potential impacts on?
    Area: backup
    Issues

@derekbit derekbit moved this from Review to Ready For Testing in Longhorn Sprint Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@roger-ryao roger-ryao

Labels
area/volume-backup-restore Volume backup restore backport/1.6.4 backport/1.7.3 kind/bug priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/qa-review-coverage Require QA to review coverage
Projects
Longhorn Sprint
Status: Ready For Testing
Milestone
v1.8.0
Development

No branches or pull requests
3 participants
@derekbit @longhorn-io-github-bot @roger-ryao