Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT][v1.4.5][IMPROVEMENT] Reject the last replica deletion if its volume.spec.deletionTimestamp is not set #7431

Closed
github-actions bot opened this issue Dec 23, 2023 · 2 comments
Closed

[BACKPORT][v1.4.5][IMPROVEMENT] Reject the last replica deletion if its volume.spec.deletionTimestamp is not set #7431

github-actions bot opened this issue Dec 23, 2023 · 2 comments
Assignees
@derekbit @roger-ryao
Labels
area/admission-webhook Kubernetes validation and mutating admission webhooks area/resilience System or volume resilience area/stability System or volume stability kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation wontfix

Comments

@github-actions
Copy link

backport #7372
@github-actions github-actions bot added area/resilience System or volume resilience area/stability System or volume stability area/admission-webhook Kubernetes validation and mutating admission webhooks kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation labels Dec 23, 2023
@github-actions github-actions bot added this to the v1.4.5 milestone Dec 23, 2023
@derekbit derekbit mentioned this issue Jan 24, 2024
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Jan 24, 2024 •
edited by derekbit
Loading

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

Create a volume with 3 replicas.
Delete first replica and second replica. When deleting the third replica, the deletion should be rejected.

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2516

  • Which areas/issues this PR might have potential impacts on?
    Area: volume, replica
    Issues

@roger-ryao roger-ryao self-assigned this Apr 17, 2024
@derekbit derekbit moved this to Ready For Testing in Longhorn Sprint Aug 3, 2024
@derekbit derekbit removed this from the v1.4.5 milestone Aug 26, 2024
@derekbit
Copy link
Member

v1.4.x is EOL.

@derekbit derekbit closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2024
@github-project-automation github-project-automation bot moved this from Ready For Testing to Closed in Longhorn Sprint Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@roger-ryao roger-ryao

Labels
area/admission-webhook Kubernetes validation and mutating admission webhooks area/resilience System or volume resilience area/stability System or volume stability kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation wontfix
Projects
Longhorn Sprint
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@derekbit @longhorn-io-github-bot @roger-ryao