Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.4.5][TASK] Bump the versions of dependent libs or components #7151

Closed
github-actions bot opened this issue Nov 21, 2023 · 12 comments
Closed
Assignees
Labels
area/csi CSI related like control/node driver, sidecars area/external-dependency External dependency related like packages on host, distro version, etc area/kubernetes Kubernetes related like K8s version compatibility kind/backport Backport request kind/task General task request to fulfill another primary request priority/0 Must be implement or fixed in this release (managed by PO) wontfix

Comments

@github-actions
Copy link

backport #7001

@github-actions github-actions bot added area/csi CSI related like control/node driver, sidecars area/external-dependency External dependency related like packages on host, distro version, etc area/kubernetes Kubernetes related like K8s version compatibility kind/backport Backport request kind/task General task request to fulfill another primary request priority/0 Must be implement or fixed in this release (managed by PO) labels Nov 21, 2023
@github-actions github-actions bot added this to the v1.4.5 milestone Nov 21, 2023
@c3y1huang
Copy link
Contributor

c3y1huang commented Nov 21, 2023

Please don't merge the PRs yet. I need to run some tests on them first. done

cc @longhorn/dev

@innobead
Copy link
Member

@c3y1huang as discussed, let's make those PRs drafted first.

@c3y1huang
Copy link
Contributor

c3y1huang commented Nov 22, 2023

Test result:

Note that the test_csi_snappshotter cases failed in full regression test due to an incompatibility between the private pipeline's csi-snapshotter (v6.2.1) and Longhorn v1.4.x.

I've re-run the related case using the public pipeline since I couldn't find an option to configure the csi-snapshotter version.

@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Nov 22, 2023

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

  • Which areas/issues this PR might have potential impacts on?
    Area kubernetes, csi, dependencies
    Issues

  • If labeled: require/LEP Has the Longhorn Enhancement Proposal PR submitted?
    The LEP PR is at

  • If labeled: area/ui Has the UI issue filed or ready to be merged (including backport-needed/*)?
    The UI issue/PR is at

  • If labeled: require/doc Has the necessary document PR submitted or merged (including backport-needed/*)?
    The documentation issue/PR is at

  • If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue (including backport-needed/*)
    The automation skeleton PR is at
    The automation test case PR is at
    The issue of automation test case implementation is at (please create by the template)

  • If labeled: require/automation-engine Has the engine integration test been merged (including backport-needed/*)?
    The engine automation PR is at

  • If labeled: require/manual-test-plan Has the manual test plan been documented?
    The updated manual test plan is at

  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at

@innobead
Copy link
Member

innobead commented Nov 29, 2023

#6920 (comment) @c3y1huang will we update the CSI sidecars as well?

@c3y1huang
Copy link
Contributor

c3y1huang commented Dec 6, 2023

#6920 (comment) @c3y1huang will we update the CSI sidecars as well?

#6920 (comment)

@innobead
Copy link
Member

innobead commented Dec 6, 2023

@c3y1huang so, CSI sidecars are only updated to master without backporting to 1.5/1.4, right?

@c3y1huang
Copy link
Contributor

c3y1huang commented Dec 6, 2023

@c3y1huang so, CSI sidecars are only updated to master without backporting to 1.5/1.4, right?

We've backported to v1.5 but not 1.4. The reason for backporting to v1.5 was that it only involved minor version upgrades, unlike v1.4, which involved major version upgrades. And I've also gone through regression testing.

@c3y1huang
Copy link
Contributor

We've backported to v1.5 but not 1.4. The reason for backporting to v1.5 was that it only involved minor version upgrades, unlike v1.4, which involved major version upgrades. And I've also gone through regression testing.

@innobead do you have any concerns?

@innobead
Copy link
Member

innobead commented Dec 6, 2023

No concerns if we have done the testing.

@c3y1huang
Copy link
Contributor

No concerns if we have done the testing.

v1.5.x full regression test result: #7150 (comment)

@derekbit
Copy link
Member

v1.4.x is EOL.

@derekbit derekbit closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2024
@github-project-automation github-project-automation bot moved this from Ready For Testing to Closed in Longhorn Sprint Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi CSI related like control/node driver, sidecars area/external-dependency External dependency related like packages on host, distro version, etc area/kubernetes Kubernetes related like K8s version compatibility kind/backport Backport request kind/task General task request to fulfill another primary request priority/0 Must be implement or fixed in this release (managed by PO) wontfix
Projects
Status: Closed
Development

No branches or pull requests

4 participants