Adding block/page unification in query #3630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@houshuang Thank you for investigating this problem! I'll give it a try tomorrow and reply later. |
tiensonqin
added a commit
that referenced
this pull request
Dec 29, 2021
Related to #3630. Full text search example in a nested query: (and [[page]] "query")
|
@houshuang The block/page unification is addressed in #3664. |
tiensonqin
added a commit
that referenced
this pull request
Dec 29, 2021
Related to #3630. Full text search example in a nested query: (and [[page]] "query")
|
Ok, closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the query_dsl.cljs file at the bottom, there is an example of a query that currently gives the wrong result.
(query "(and (page-property foo bar) [[hello]])"))Currently asking for blocks on pages matching a certain query, like page-property, results in all eligible blocks being listed, whether or not they are on pages with that page property.
The problem seems to be that in the generated datalog query, there are conditions on the page
?pand the block?b, but there is no link between the two - no condition that?bbe on a page?p. When adding that condition to the query (['?b :block/page '?p]), we get the desired results.However, it is not clear to me exactly where to add this string in the code. On one hand, it does not seem to do any harm to add this link whether or not there are actual block conditions (ie. a pure page query with this where clause added still works). However, this does not take into account cases like
(or (page-property a) [[a]]), nested and/ors etc. Therefore I am submitting this PR merely as an illustration, and I hope someone who understands the query parser logic better than me can help implement this properly.I'd love to see this addressed, since this to me is a major improvement over Roam, and potentially incredibly useful in many use cases (show me all writings on "method" only from papers about biology - based on a page-property science-field biology for example).
Tweeted a little walkthrough video (more for people interested in Logseq development, not necessary to understand this PR)
https://www.loom.com/share/a849904da94043c69e09a1a95d8e7e1a