Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source formatting settings #130

Open
vanowm opened this issue Oct 27, 2022 · 6 comments
Open

Source formatting settings #130

vanowm opened this issue Oct 27, 2022 · 6 comments

Comments

@vanowm
Copy link

vanowm commented Oct 27, 2022

@loganch do you think, maybe you could share your formatting settings, so they could be used for PRs?

@loganch
Copy link
Owner

loganch commented Oct 28, 2022

My formatting is based on the airbnb-base through eslint and prettier, which depends on the eslint, eslint-config-airbnb-base, eslint-config-prettier, eslint-plugin-import, eslint-plugin-prettier and prettier devDependencies. I also have the eslint extension https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint installed that surfaces the formatting issues into the problem tab.

@vanowm
Copy link
Author

vanowm commented Apr 27, 2023

Maybe eslint settings should be included in the repo? Just enabled it on my end and every file has "issues", because my settings are not the same...

@loganch
Copy link
Owner

loganch commented Apr 28, 2023

They already were (.eslintrc.json, .prettierrc.json).

I just realized that I didn't include a link to the Prettier extension, which I also have installed, but I feel like it's only for formatting and wouldn't have an effect on seeing issues everywhere since all of that is covered through ESLint.

@vanowm
Copy link
Author

vanowm commented Apr 29, 2023

That is strange, I have these extensions installed and get a lot of errors:
image

@loganch
Copy link
Owner

loganch commented Apr 29, 2023

That actually looks about right for ai_command.js, here's how it looks on my side:

image

Are you seeing any problems show for say, extension.js or ai_signature.js

@vanowm
Copy link
Author

vanowm commented May 13, 2023

No, these are fine, however, ai_commands.js is pretty much unusable:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants